lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by ad


From: pkx166h
Subject: Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by address@hidden)
Date: Wed, 09 Jul 2014 21:42:41 +0000


https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely#newcode68
Documentation/changes.tely:68: Add support for @address@hidden
On 2014/07/04 07:17:26, Mark Polesky wrote:
@address@hidden
OK

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely#newcode71
Documentation/changes.tely:71: It is now possible to individually color
both the dots and parenthesis
On 2014/07/04 07:17:26, Mark Polesky wrote:
parentheses

Done.

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely#newcode111
Documentation/changes.tely:111: space between the dot and the
parenthesis surrounding it.
On 2014/07/04 07:17:26, Mark Polesky wrote:
parentheses

Done.

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely#newcode143
Documentation/changes.tely:143: spaced using only its @emph{left-edge}
as reference point.  This ensures
On 2014/07/05 17:46:15, Keith wrote:
David K was talking about making fill-line use reference points where
your
capital 'O's are placed, but (correctly) didn't do that.  Reference
points are
not a helpful concept for explaining two functions.

As Dan suggested, different-length words make it clear.
\fill-line sets in columns; \justify-line balances whitespace

\paper { #(set-paper-size "a6" ) }
\markup \fill-line {ooo ooo ooo ooo}
\markup \fill-line {ooooooooo oooooooo oo ooo}
\markup \justify-line {vvv vvv vvv vvv}
\markup \justify-line {vvvvvvvvv vvvvvvvv vv vvv}

Thanks. I've taken your suggestions and remade the example. I didn't see
the point of using different charachters for each command so stuck
with the 'oooo' and included the paper size in the lilypond-book
settings to keep the example cleaner.

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely#newcode151
Documentation/changes.tely:151: \fill-line {Ooooo oOooo ooOoo oooOo
ooooO}
On 2014/07/04 07:17:26, Mark Polesky wrote:
I prefer this:
\fill-line \underline {"↓    " " ↓   " "  ↓  " "   ↓ " "    ↓"}

See Keith's comment above.

https://codereview.appspot.com/108130043/diff/90001/Documentation/changes.tely#newcode156
Documentation/changes.tely:156: \justify-line {Ooooo Ooooo Ooooo Ooooo
Ooooo}
On 2014/07/04 07:17:26, Mark Polesky wrote:
I prefer this:
\justify-line \underline {"↓    " "↓    " "↓    " "↓    " "↓    "}

See Keith's comment above

https://codereview.appspot.com/108130043/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]