Re: Create a \tuplet function to complement \times and tupletSpannerDuration (issue 7058068)

[dak]

Ok, most of this is obsolete due to myself not managing reviews
properly.  The current review for issue 3095 is to be found at
<URL:http://codereview.appspot.com/7094044>.  I am closing this one
down.  Apologies.

On 2013/01/11 18:28:35, Ian Hulin (gmail) wrote:
> I don't think \tuplet needs the tupletSpannerDuration property. Do it
all
> in-line using the optional @var{duration} parameter.  (Maybe call this
> spanner-duration). See comments below.

See current patch: tupletSpannerDuration is not touched.  It is only
used when the optional duration argument is not given.  If one wanted to
rename the duration argument, in line with the current proposal it would
likely best be named tuplet-span .


https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly
> File ly/music-functions-init.ly (right):


https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly#newcode1344
> ly/music-functions-init.ly:1344: being played in place of two.  If the
optional
> @var{duration} is
> If the optional @var{duration} parameter is specified, this is used to
have the
> tuplet use spanner brackets differing from the total length of the
music in the
> tuplet. Typically this could be used to specify a group of
subdivisions within
> the tuplet.
> For example,


https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly#newcode1351
> ly/music-functions-init.ly:1351: quarter note.  The value of
> @code{tupletSpannerDuration} is retained
> Cut out these sentences
> "The value of @code{tupletSpannerDuration} is retained as default if
it is set
> in this manner. Clearing it can be achieved by specifying @samp{1*0}
as
> @var{duration}"

Isn't there in the current version.


https://codereview.appspot.com/7058068/diff/4/ly/music-functions-init.ly#newcode1372
> ly/music-functions-init.ly:1372:
> Get rid of code doing things to tupletSpannerDuration.  I think this
property
> was a kludge they put in because you couldn't code an optional
parameter when
> the old \times commands was written.
> Look at the NR example for tupletSpannerDuration:

> {
>    \set tupletSpannerDuration = #(ly:make-moment 1 4)
>    \times 2/3 { c8 c c c c c }
> }

> WDYT?

Well, the last proposal is pretty much already where you wanted it to
be.  Check out the above named Rietveld report, and sorry for starting
so many of them.  One of them was a git-cl problem.

https://codereview.appspot.com/7058068/