lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixing issue 37 with extra position callback (issue3928041)


From: Carl . D . Sorensen
Subject: Re: Fixing issue 37 with extra position callback (issue3928041)
Date: Sun, 09 Jan 2011 02:40:12 +0000

LGTM.

Don't forget to fix your copyright on beam-collision-engraver.

One set of braces to be removed.

Thanks,

Carl



http://codereview.appspot.com/3928041/diff/17001/lily/beam-collision-engraver.cc
File lily/beam-collision-engraver.cc (right):

http://codereview.appspot.com/3928041/diff/17001/lily/beam-collision-engraver.cc#newcode4
lily/beam-collision-engraver.cc:4: Copyright (C) 1997--2010 Han-Wen
Nienhuys <address@hidden>
Copyright 2011 Mike Solomon

http://codereview.appspot.com/3928041/diff/17001/lily/beam.cc
File lily/beam.cc (right):

http://codereview.appspot.com/3928041/diff/17001/lily/beam.cc#newcode969
lily/beam.cc:969: {
No brackets here

http://codereview.appspot.com/3928041/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]