[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixing issue 37 with extra position callback (issue3928041)
From: |
Mike Solomon |
Subject: |
Re: Fixing issue 37 with extra position callback (issue3928041) |
Date: |
Sat, 8 Jan 2011 14:48:02 -0500 |
All is fixed. Attached is the original patch plus one with Carl's suggested
formatting changes.
I ran all of the regtests and nothing breaks.
I'd like one other person to test these patches out w/ the attached .ly
document to confirm. Then, if there are no other other comments, please push
the patches and close the Google issue.
Cheers,
MS
0002-Fixes-formatting-problems.patch
Description: Binary data
0001-Fixing-issue-37-with-extra-position-callback.patch
Description: Binary data
37.robust.ly
Description: Binary data
On Jan 8, 2011, at 2:17 PM, Carl Sorensen wrote:
> On 1/8/11 12:14 PM, "address@hidden" <address@hidden> wrote:
>
>> Carl,
>>
>> Thanks for the comments!
>> I've integrated all but one of them - when you say "Also add to TabStaff,"
>> what do you mean? I was under the impression that TabStaff would inherit
>> this
>> engraver because it inherits from Staff.
>
> If it does, then no problem.
>
> Thanks,
>
> Carl
>