lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixing issue 37 with extra position callback (issue3928041)


From: Mike Solomon
Subject: Re: Fixing issue 37 with extra position callback (issue3928041)
Date: Sat, 8 Jan 2011 22:13:27 -0500

Done - attached is a fresh patch set.  The first three are what's already on 
Rietveld, and the 4th is Carl's formatting & copyright changes.

Cheers,
MS

Attachment: 0004-Changes-suggested-by-Carl.patch
Description: Binary data

Attachment: 0003-Intermediary-37-patch.patch
Description: Binary data

Attachment: 0002-Fixes-formatting-problems.patch
Description: Binary data

Attachment: 0001-Fixing-issue-37-with-extra-position-callback.patch
Description: Binary data

On Jan 8, 2011, at 9:40 PM, address@hidden wrote:

> LGTM.
> 
> Don't forget to fix your copyright on beam-collision-engraver.
> 
> One set of braces to be removed.
> 
> Thanks,
> 
> Carl
> 
> 
> 
> http://codereview.appspot.com/3928041/diff/17001/lily/beam-collision-engraver.cc
> File lily/beam-collision-engraver.cc (right):
> 
> http://codereview.appspot.com/3928041/diff/17001/lily/beam-collision-engraver.cc#newcode4
> lily/beam-collision-engraver.cc:4: Copyright (C) 1997--2010 Han-Wen
> Nienhuys <address@hidden>
> Copyright 2011 Mike Solomon
> 
> http://codereview.appspot.com/3928041/diff/17001/lily/beam.cc
> File lily/beam.cc (right):
> 
> http://codereview.appspot.com/3928041/diff/17001/lily/beam.cc#newcode969
> lily/beam.cc:969: {
> No brackets here
> 
> http://codereview.appspot.com/3928041/


reply via email to

[Prev in Thread] Current Thread [Next in Thread]