Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120)

[Neil Puttock]

2008/6/12 Reinhold Kainhofer <address@hidden>:
> Am Mittwoch, 11. Juni 2008 schrieb Neil Puttock:

> Here is an updated patch with all the issues resolved. I've also added a
> regression test, the corresponding PDF file is uploaded at:
> http://www.fam.tuwien.ac.at/~reinhold/temp/metronome-text.pdf

Excellent.

I think there are just two issues remaining:

- since format-metronome-markup determines whether to create the text
markup by checking for an empty list, you probably want the parser to
send SCM_EOL for \tempo dur = count; otherwise you'll get the
unfortunate result shown below. :)

- ideally, you need two concat operations to prevent the spaces around
the equals sign being lost.

>> Could the tempo function be rewritten to incorporate the other
>> options, with default values being passed by the parser for the
>> properties not set?
>
> Which other options are you talking about?

The two extra syntax constructors (one of which you've now
incorporated into tempo).

Regards,
Neil

foo.png
Description: PNG image