Re: [PATCH] Optionally add text to metronome marks (i.e. allow \tempo "Allegro" 4=120)

[Neil Puttock]

2008/6/6 Reinhold Kainhofer <address@hidden>:

> Attached is a patch (for current master), which is my first attempt to implent
> this. The patch is not perfect yet, but works really well. What it does:
>  - Extend the parser to allow the above forms for \tempo
>  - Add a tempoText property, similar to tempoUnitCount
>  - Metronome_mark_engraver uses this property and checks whether it has
>     changed
>  - Extend the metronomeMarkFormatter to take four arguments (text, duration,
>    count, context) and print either the text, the note=count or text
>    (note=count), depending on whether the properties are set to sensible
>    values.

That's really good.

If I might make a suggestion, it would be nice to have an additional
feature whereby the tempo can be set silently (perhaps controlled by a
boolean context property), which would allow the text to be displayed
while preserving the default behaviour of \tempo.

> So, what shall I change in the patch?

Do you need to have two extra functions in ly-syntax-constructors.scm?
They seem a bit out of place there, since they're too specific (being
a subset of tempo).

Could the tempo function be rewritten to incorporate the other
options, with default values being passed by the parser for the
properties not set?

Regards,
Neil