[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libunwind-devel] [PATCH 05/11] build: make libunwind-coredump build

From: Cody P Schafer
Subject: Re: [Libunwind-devel] [PATCH 05/11] build: make libunwind-coredump build optional
Date: Tue, 11 Sep 2012 15:41:55 -0700
User-agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0

On 09/11/2012 10:15 AM, Mike Frysinger wrote:
On Tue, Sep 11, 2012 at 8:43 AM, Cody P Schafer wrote:
On Mon 10 Sep 2012 06:29:47 PM PDT, Mike Frysinger wrote:
On Mon, Sep 10, 2012 at 8:21 PM, Cody P Schafer wrote:

--- a/tests/
+++ b/tests/

   EXTRA_DIST =   run-ia64-test-dyn1 run-ptrace-mapper run-ptrace-misc
-               run-check-namespace run-coredump-unwind \
-               run-coredump-unwind-mdi \
+               run-check-namespace  \
+       \
                  Gtest-nomalloc.c Gtest-nocalloc.c
+ EXTRA_DIST += run-coredump-unwind-mdi run-coredump-unwind

i don't think EXTRA_DIST should be conditionalized.  it's what goes
into the tarball made by `make dist`, and that should always be the
same regardless of `./configure` options.

The problem here is that run-coredump-unwind-mdi & run-coredump-unwind
_can't_ build without libunwind-coredump being built. And removing them from
EXTRA_DIST prevents them from being built.

huh ?  these two files are shell scripts.  there's nothing to "build".
  so pretty sure this hunk is wrong.

Yep, you're right. I must have been overzealous when trimming the build.
Will fix.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]