[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCH 07/11] ppc64: remove compile warnings from
|
From: |
Tommi Rantala |
|
Subject: |
Re: [Libunwind-devel] [PATCH 07/11] ppc64: remove compile warnings from wchar test. |
|
Date: |
Tue, 11 Sep 2012 09:09:41 +0300 |
2012/9/11 Mike Frysinger <address@hidden>:
> On Mon, Sep 10, 2012 at 8:21 PM, Cody P Schafer wrote:
>> - int i;
>> + unsigned i;
>> int ret;
>>
>> - printf("wcslen(wstring) = %d\n", wcslen(wstring));
>> + printf("wcslen(wstring) = %lu\n", (long unsigned) wcslen(wstring));
>
> NAK: wcslen returns a size_t. you should use that type for "i", and
> then use %zu.
Since nobody has any idea why the test should exist in libunwind, can
we please just "git rm" it.
Tommi
- Re: [Libunwind-devel] [PATCH 10/11] configure: introduce AX_ARG_ENABLE., (continued)
[Libunwind-devel] [PATCH 09/11] configure: use AC_ARG_ENABLE's defaults when possible, Cody P Schafer, 2012/09/10
[Libunwind-devel] [PATCH 08/11] configure: avoid using a shell function in autoconf, Cody P Schafer, 2012/09/10
[Libunwind-devel] [PATCH 03/11] ppc32: add used attribute to dmy_ctxt, Cody P Schafer, 2012/09/10
[Libunwind-devel] [PATCH 07/11] ppc64: remove compile warnings from wchar test., Cody P Schafer, 2012/09/10
[Libunwind-devel] [PATCH 04/11] ppc32: ppc64: test altivec support by running the compiler., Cody P Schafer, 2012/09/10
[Libunwind-devel] [PATCH 05/11] build: make libunwind-coredump build optional, Cody P Schafer, 2012/09/10
[Libunwind-devel] [PATCH 11/11] UPT: Add reg offsets for ppc32/64, Cody P Schafer, 2012/09/10