[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libunwind-devel] [PATCH 07/11] ppc64: remove compile warnings from

From: Cody P Schafer
Subject: Re: [Libunwind-devel] [PATCH 07/11] ppc64: remove compile warnings from wchar test.
Date: Tue, 11 Sep 2012 08:50:45 -0700
User-agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0

On 09/10/2012 11:09 PM, Tommi Rantala wrote:
2012/9/11 Mike Frysinger <address@hidden>:
On Mon, Sep 10, 2012 at 8:21 PM, Cody P Schafer wrote:
-  int i;
+  unsigned i;
    int ret;

-  printf("wcslen(wstring) = %d\n", wcslen(wstring));
+  printf("wcslen(wstring) = %lu\n", (long unsigned) wcslen(wstring));

NAK: wcslen returns a size_t.  you should use that type for "i", and
then use %zu.

Since nobody has any idea why the test should exist in libunwind, can
we please just "git rm" it.

Got it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]