Re: patch and request

[Marcus Brinkmann]

On Thu, Sep 18, 2003 at 11:46:35AM +0200, Bas Wijnen wrote:
> To try some things out, I want to make a boot floppy which starts, for
> example, the "demo system" mentioned in wortel/README.

This is by all means trivial to achieve.  Just install grub on a floppy,
with an appropriate menu.lst file, and put all required files on the floppy.

< I can probably find
> out how to do it, but it would be nice to have a document which describes how
> it is done, and why every step is taken.

There have been various people writing scripts to create boot floppies and
populate them with files.  Just google around, or read the grub manual.

> If someone who knows would write
> that, I think it would be nice for newcomers like myself to learn about the
> system.  If not, I think I'll check it out and write it myself.

Well, certainly testing is important.  But if I had to create floppy for
booting every time I wanted to try something, I would quickly go insane. 
Peter send me his excellent bochs setup, which I now use:  You boot grub
from bochs, and set it up to fetch the menu.lst file over a virtual
ethernet card (tunnel device) from the network via tftp.  All files are also
"downloaded" via tftp.  So, what I do to test a new version is to
"sudo cp wortel /tftpboot/bochs" and then press the reset button in the
bochs window.

This is mostly interesting for developers.  But then, if you are not a
developer, or wantt o very quickly become one, why would you follow this
list :)

> ChangeLog entry:
> 
> 2003-09-18  Bas Wijnen  <address@hidden>
> 
>       * laden/ia32-cmain.c: Changed incorrect 0x2ff to ((1 << 10) - 1).

We always mention the function name in which the change happened.

BTW, I think I will define a constant L4_MIN_PAGE_SIZE in one of our l4
headers.  This magic 10 occurs very often, for example also in physmem.

>       * laden/laden.c: Updated help text to match program functionality.

Likewise, the function name is missing.

> @@ -258,10 +258,10 @@

Please submit patches made with "-p" option to diff, so we can see the
function names here, too.

And thanks for the patch!  Regard the comments above as for the future, you
don't need to send in another version of this patch.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    address@hidden
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/
address@hidden
http://www.marcus-brinkmann.de/