help-octave
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [OctDev] My first contribution to Octave


From: Lukas Reichlin
Subject: Re: [OctDev] My first contribution to Octave
Date: Mon, 6 Jul 2009 13:00:07 +0200

On 06.07.2009, at 10:38, Luca Favatella wrote:

Please see this commit
http://octave.svn.sourceforge.net/viewvc/octave?view=rev&revision=5986

I added the file svplot.m refactoring it a bit (doc and coding style),
and added it to the index.
Please tell me if it is ok or if I forgot something.

Can you please post some tests for this function?
(1 or 2 will suffice, even simple ones, without involving graphical output)
You can use this file as a reference (see the last lines)
http://octave.svn.sourceforge.net/viewvc/octave/trunk/octave-forge/main/control/inst/place.m?revision=5857&view=markup

Thanks for cleaning up things! I have to figure out first how these tests work. Are they executed automatically in some way? Then I need to think of some good examples. Additionally, I shouldn't forget testing with discrete models. I don't know if it works yet. 

Please consider that I am only an engineering student and I don't
understand very well what your code is doing.


Thanks for all your work,
Luca Favatella

Yet another student :-) I will try to improve comments for better understanding of the code.

Regards,
Lukas

reply via email to

[Prev in Thread] Current Thread [Next in Thread]