[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Build failures on Ubuntu due to gettext
From: |
Carles Pina i Estany |
Subject: |
Re: Build failures on Ubuntu due to gettext |
Date: |
Wed, 9 Dec 2009 23:57:27 +0000 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi Vladimir, Colin,
On Dec/08/2009, Vladimir '??-coder/phcoder' Serbinenko wrote:
> > My patch made the following transformation:
> >
> > - grub_printf (_("literal string"));
> > + grub_printf ("%s", _("literal string"));
> >
> > This was only necessary in five places, so I doubt that a function is
> > worth it.
> >
> Then it's not worth it. But again we haven't gettext'ized whole grub2
> yet to know for sure. Perhaps a macro so we can change it later if
> necessary?
Vladimir, Colin: see the attached patch with the Colin changes but
macrofied.
Should compile fine in Ubuntu, but I have not tried.
Are we happy with grub_put_ function name?
Colin: could you apply this patch or similar?
I don't want to push more gettext strings before setting up the basic
infrastructure to avoid working twice.
Thanks,
--
Carles Pina i Estany
http://pinux.info
grub_put_.patch
Description: Text Data
Re: Build failures on Ubuntu due to gettext, Vladimir 'φ-coder/phcoder' Serbinenko, 2009/12/07
- Re: Build failures on Ubuntu due to gettext, Colin Watson, 2009/12/07
- Re: Build failures on Ubuntu due to gettext, Colin Watson, 2009/12/07
- Re: Build failures on Ubuntu due to gettext, Vladimir 'φ-coder/phcoder' Serbinenko, 2009/12/07
- Re: Build failures on Ubuntu due to gettext, Colin Watson, 2009/12/07
- Re: Build failures on Ubuntu due to gettext, Vladimir 'φ-coder/phcoder' Serbinenko, 2009/12/07
- Re: Build failures on Ubuntu due to gettext,
Carles Pina i Estany <=
- Re: Build failures on Ubuntu due to gettext, Carles Pina i Estany, 2009/12/09
- Re: Build failures on Ubuntu due to gettext, Carles Pina i Estany, 2009/12/09
Re: Build failures on Ubuntu due to gettext, Robert Millan, 2009/12/09
Re: Build failures on Ubuntu due to gettext, Carles Pina i Estany, 2009/12/10
Re: Build failures on Ubuntu due to gettext, Carles Pina i Estany, 2009/12/07