[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] memtest86+ fix

From: Robert Millan
Subject: Re: [PATCH] memtest86+ fix
Date: Thu, 3 Jan 2008 02:06:37 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Thu, Jan 03, 2008 at 12:46:15AM +0100, Yoshinori K. Okuji wrote:
> On Wednesday 02 January 2008 18:05, Robert Millan wrote:
> > This fixes boot for memtest86+ (and actually, Linux zImages since they were
> > all affected).
> >
> > The problem was that the first code in grub_linux_boot_zimage copied the
> > payload from  0x100000 to 0x10000.  Since GRUB starts at 0x8200 and is
> > typicaly more than 8 kiB in size, it'll most likely overwrite part of it.
> >
> > A bit of reestructuring was necessary to allow grub_dl_unload_all() to
> > happen unconditionally as first step, since the information on whether this
> > is a "big linux" was not promptly available.
> >
> > Comments?
> It is okay, except for "grub_linux_big"... I cannot figure out what it wants 
> to say. As you want to make it global, please choose a more expressive name, 
> such as "grub_big_linux_loaded".

How about "grub_linux_big_loaded", for consistency with the other vars in
<machine/kernel.h> that also start with grub_linux_ ?

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]