[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makef
From: |
Ralph Corderoy |
Subject: |
Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil... |
Date: |
Thu, 18 Apr 2013 12:37:43 +0100 |
Hi,
Werner wrote:
> Thanks, this is fine now. A minor issue:
>
> + -test -d "$(DESTDIR)$(bindir)" || \
> + $(mkinstalldirs) "$(DESTDIR)$(bindir)";
>
> If you break a line, please start the new line with the operator:
>
> -test -d "$(DESTDIR)$(bindir)" \
> || $(mkinstalldirs) "$(DESTDIR)$(bindir)";
(Interesting. I have binary operators at the end of the line as, like a
hyphen in text, they indicate there's more to follow.)
> Well, if a line gets continued with `\', no tabs are necessary. Ah, I
> now see that you've removed the line continuation mark, so this line:
>
> $(srcdir)/grog.pl >$@;
> chmod +x $@;
>
> should rather be
>
> $(srcdir)/grog.pl >$@; \
> chmod +x $@;
The former will have make(1) stop if grog.pl fails whereas the latter
will ignore that and use chmod's success. `&&' would avoid this in the
latter though I wonder, without context, if the two commands need to be
in the one sh invocation? Both create $@ even on failure, perhaps
causing the target to be considered `built' next time. `grog.pl >address@hidden
&& mv address@hidden $@' might help.
Cheers, Ralph.
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil..., Werner LEMBERG, 2013/04/16
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil..., Bernd Warken, 2013/04/16
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil..., Werner LEMBERG, 2013/04/17
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...,
Ralph Corderoy <=
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil..., Werner LEMBERG, 2013/04/18
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil..., Keith Marshall, 2013/04/18
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil..., Ralph Corderoy, 2013/04/18
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil..., Heinz-Jürgen Oertel, 2013/04/18
- Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil..., Ralph Corderoy, 2013/04/18