[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makef

From: Werner LEMBERG
Subject: Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefil...
Date: Tue, 16 Apr 2013 07:14:24 +0200 (CEST)


this is still not OK.

> RCS file: /cvsroot/groff/groff/INSTALL.gen,v
> retrieving revision 1.7
> retrieving revision 1.8
> diff -u -b -r1.7 -r1.8

*Never* change this file manually!  It is a generic one provided from
GNU (normally called `INSTALL').  Please restore it (or get the newest
version from the `gnulib' or `automake' git repository).

> RCS file: /cvsroot/groff/groff/aclocal.m4,v
> [...]
> +# ===========================================================================
> +#
> +# ===========================================================================
> [...]

As told earlier, such stuff shouldn't be in this file; there should
only be lines of the form


The reason for this problem is that you are using the macro
AX_PROG_PERL_VERSION (in `groff.m4') without adding the file
`ax_prog_perl_version.m4' to the repository.

> RCS file: INSTALL.autotools

I think this is the wrong file name; I would rather call it
`INSTALL.CVS'.  And it makes only sense to have it in case the
`configure' script and all other generated files are removed from the

Two other minor issues:

. file `groff.m4':

  @@ -134,6 +148,7 @@
        AC_MSG_WARN([missing program$plural:
     The program$plural
     cannot be found in the PATH.
     Consequently, groff's HTML backend (grohtml) will not work properly;

  Why the additional newline?  If you do so, I would rather expect to
  have another one after the `$missing' line also.

. file `':

  All variables which are defined globally should be added to the
  `MDEFINES' definition.  You haven't done so for `PERLVERSION'.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]