grep-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grep-3.3.42-088f test results on AIX


From: Bruno Haible
Subject: Re: grep-3.3.42-088f test results on AIX
Date: Thu, 26 Dec 2019 10:16:29 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-170-generic; KDE/5.18.0; x86_64; ; )

Hi Paul,

> That problem is in /bin/sh's printf command, not in grep. In a UTF-8 locale
> "printf '\351'" outputs the bytes C3, A9 rather than the desired E9; 
> apparently
> printf is taking the \351 to be a character rather than the byte

Indeed.

> I installed the attached patch to work around the problem

Setting LC_ALL=C in the test setup greatly reduces the test coverage. As far as
I can see, so far, all the grep tests that work on plain ASCII inputs and
patterns were tested in the locale the user happens to be in. But with your
patch, these tests will only be tested in the C locale.

I would suggest to revert this, and to set LC_ALL=C only for the printf
statements. Patch attached.

By the way, init.sh is periodically copied from gnulib into grep; therefore
changes to the grep test suite belong in init.cfg, not init.sh.

Bruno

Attachment: 0001-tests-Work-around-AIX-7.2-sh-printf-bug-differently.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]