gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GNUstep releases this month?


From: Richard Frith-Macdonald
Subject: Re: GNUstep releases this month?
Date: Mon, 22 Mar 2021 18:03:52 +0000


> On 22 Mar 2021, at 17:41, Frederik Seiffert <frederik@algoriddim.com> wrote:
> 
> 
> 
>> Am 22.03.2021 um 18:19 schrieb Richard Frith-Macdonald 
>> <richard@frithmacdonald.me.uk>:
>> 
>> I was just looking at that.  The tests are passing for me on debian-10 (gcc) 
>> and fedora-33 (with both gcc and clang with libobjc2 from some months ago)
> 
> That’s good at least.
> 
>> I'm guessing that the issue is a recent libobjc2 one though.
> 
> This libobjc2 change would fit timing-wise, as it was done 2 days before my 
> commits but after the previous commits in Base that were still passing:
> https://github.com/gnustep/libobjc2/commit/73132a6c9832d939f190742a326663a7dcebd339
> 
> I saw that in [GSFileHandle dealloc] we are calling -retain, which seems 
> unusual – not sure if that is supported by the runtime? If not, since we’re 
> throwing an exception anyway maybe we could just remove that call, or 
> implement the singleton differently by overriding retain/release?
> 
> Also that test seems a bit misguided, as we’re calling release on an 
> autoreleased object...

IIRC the standard/historic behavior is that an object can retain itself in the 
-dealloc method, to extend its own lifetime, and I guess that the singletons do 
that (I haven't checked).
I think that behavior changed for ARC, so it could be that the runtime is 
performing an ARC style deallocation when it should be calling 
NSDeallocateObject() (or something odd is going on in the NSDeallocateObject() 
function).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]