[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnushogi-devel] [PATCH] my patch

From: Chen Chen
Subject: Re: [Gnushogi-devel] [PATCH] my patch
Date: Thu, 17 Jul 2014 12:08:48 +0800


I'm *sorry* for sending this twice. I forgot to CC mail list in the
previous one.

On Thu, 17 Jul 2014 00:38:55 +0200, Yann Dirson wrote:
> > Here's my patch. Hope I'm using "git send-mail" correctly.
> Not bad for a first ;)

Sweet, thanks :)

> It's nevertheless a good idea to split commits when it includes
> changes that are described differently.

I'll keep this in mind.

> * OTOH, I'm not sure it is reasonable to have the build fail when
>   makeinfo is missing, I'd think a warning ought to be enough,
>   especially as the .info file is included in the dist tarball, and is
>   more recent than the .texi, and as such its rebuild should not be
>   triggered by default.

I made a mistake here. The compilation will fail when directly using git
repo, but it worked as intended in "make dist" tarball (the command will
regenerate a proper .texi). Since the failure message already pointed
out "missing texinfo" in make procedure, the makeinfo check in is not really necessary.

> Hopefully the makeinfo part is not critical for your package, and
> you'll be able to use the new master.

I can explicitly indicate this in "BuildRequired" Section in RPM spec.
The texinfo-related patch is only a (wrong) feedback instead of

> > Another problem is, the package cannot properly "make distcheck".
> > It seems the two ".inc" files are generated by "pat2inc" during
> > build time but didn't get proper deletion in "make clean" stage.
> Good catch, I apparently missed some extra declaration.  Also noted in
> README.maint not to forget "make distcheck".

The automake manual has an FAQ article on this error:
I know I can mark them for clean by directly modify the, but
don't know how to express the rule in

> > In addition, I don't know what these two files are doing. In a rough
> > skim reading, I didn't find any source files utilizing them.
> "git grep -F .inc" shows they are included by pattern.c.

But apparently the "cross-compile" section doesn't even need pat2inc. So
I'm a bit confused.

Thanks for your great work on this game! I'm a big fan (and a poor
player, shamefully) of Shogi.
Chen Chen <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]