[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnushogi-devel] [PATCH] my patch

From: Chen Chen
Subject: [Gnushogi-devel] [PATCH] my patch
Date: Tue, 15 Jul 2014 14:44:44 +0800


Here's my patch. Hope I'm using "git send-mail" correctly.

Following your advices (Yann, H.G. thank you), I will package the srpm
as two parts: the original git snapshot and the patch.

The result is not so smooth, since it require "autoreconf -i" in
"%prep" stage of rpmbuild, thus introducing dependency requirements on
autoconf, m4, perl etc., but I'll try it.

Another problem is, the package cannot properly "make distcheck".
It seems the two ".inc" files are generated by "pat2inc" during build
time but didn't get proper deletion in "make clean" stage. In addition,
I don't know what these two files are doing. In a rough skim reading,
I didn't find any source files utilizing them.

After some fine tweaks I'll update the srpm package on bugzilla and in
the list.

Response to Yann:

> Well, you can still run "make install prefix=/whatever/usr", although it
> is not as modern :)

Yes I can, but then I need a handmade "make install prefix=%{buildroot}"
instead of macro "%make_install", and it will (at least on my PC) fire
a "check-buildroot failure" in rpmbuild finalization because the generated
spec file will contain absolute path.

> Beware, you have an autom4te.cache that went into the source tarball.
> To get a more official source tarball, I advise you just use "make dist".

Ouch! I forgot that. Thanks for reminding.

> I am also puzzled by the need for AM_PROG_CC_C_O

Automake use this macro to check if it can use "$CC -c foo -o bar" together.
The macro is probably invented in recent editions.

*** BLURB HERE ***

Chen Chen (1):
  Misc fixes to comply with new autoconf standard;     Add a pre-build
    check on texinfo. | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]