Re: [GNU Crypto] Passwords Immutable?

[Casey Marshall]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Bryan" == Bryan Hoover <address@hidden> writes:

Bryan> Casey Marshall wrote:
>> One thing you should do is format your source code according to our
>> formatting standards, for new files:
>> 
>> <http://www.gnu.org/software/gnu-crypto/code-formatting.html>
>> 
>> Existing files should be formatted in that file's style.
>> 
>> You should also use CVS to create unified diffs (diff -u), if
>> possible.

Bryan> Done.  And thanks for the tips.  I received 'assignment process
Bryan> complete' notification from Ted (copyright clerk) yesterday.

Bryan> Password.java, and unified diff for changes to SRPClient, and
Bryan> SaslConnection attached.

Bryan> The diff is relative to gnu-crypto/source directory.

Merged into CVS HEAD. A couple of comments:

   - It's our convention to not use redundant modifiers and
     declarations; this includes `throws' clauses for unchecked
     exceptions (although, they should be described in a address@hidden'
     entry in the javadocs, if it is a public or protected method).

   - `doDestroy' shouldn't throw a DestroyFailedException, since it is
     a serious bug if an exception is thrown when erasing passwords
     (i.e., doDestroy should never fail in this class).

   - `password' and `bPassword' are declared as `final', and they are
     initialized in the constructor (there really wasn't any need for
     the init* methods).

   - I put Password into the package gnu.crypto.auth. I'm certain that
     this class will be useful in other places. The next thing to do
     is replace char arrays with Password wherever else appropriate.

Cheers,

- -- 
Casey Marshall || address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.7 <http://mailcrypt.sourceforge.net/>

iD8DBQFAlBOXgAuWMgRGsWsRAgtsAJwIHf57svCdMp0sTUbWg5N4OOGRBgCbBhv7
bCqtWwSEY/Z/uiW9IZzF8Gc=
=DjJW
-----END PGP SIGNATURE-----