Re: [GNU Crypto] Mauve tests

[Mark Wielaard]

Hi,

On Sat, 2002-12-14 at 09:21, Raif S. Naffah wrote:
> i just checked in Mauve tests, and all the necessary machinery to run 
> them --when building a GCJ-friendly version of the library.

Very nice. Thanks.

I would like to propose a few small changes that make the test output
cleaner. I really like it if a make check only gives actual failure
output (if any) and a summary of the test results but nothing else. This
is what an end user is really interested in IMHO. So what I have in my
source tree is:

  * gcj/source/Makefile.am (check-local): Call mauveTest without flags
  or extra environment variables set.

  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfAnubis.java: Call
  harness.debug(x), not x.printStackTrace().
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfBlowfish.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfCipherFactory.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfKhazad.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfNistVectors.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfNullCipher.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfRijndael.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfSerpent.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfSquare.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/cipher/TestOfTwofish.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/hash/TestOfHashFactory.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/hash/TestOfMD2.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/hash/TestOfMD4.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/hash/TestOfMD5.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/hash/TestOfRipeMD128.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/hash/TestOfRipeMD160.java:
  Likewsie.
  * gcj/source/gnu/testlet/gnu/crypto/hash/TestOfSha160.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/hash/TestOfWhirlpool.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/mac/TestOfHMacFactory.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/mac/TestOfMacFactory.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/mac/TestOfTMMH16.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/mode/TestOfCBC.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/mode/TestOfECB.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/mode/TestOfModeFactory.java:
  Likewiese.
  * gcj/source/gnu/testlet/gnu/crypto/mode/TestOfOFB.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/pad/TestOfPKCS7.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/pad/TestOfPadFactory.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/pad/TestOfTBC.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/prng/TestOfARCFour.java: Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/prng/TestOfICMGenerator.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/sig/TestOfKeyPairGeneratorFactory.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/sig/TestOfSignatureFactory.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/sig/rsa/TestOfRSACodec.java:
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/sig/rsa/TestOfRSAKeyGeneration.java
  Likewise.
  * gcj/source/gnu/testlet/gnu/crypto/sig/rsa/TestOfRSAPSSSignature.java:
  Likewise

  * source/gnu/crypto/exp/ust/UST.java (selfTest): Remove System.out
  calls.

   * source/gnu/crypto/jce/prng/ICMRandomSpi.java (DEBUG): Set to false.
  * source/gnu/crypto/jce/prng/UMacRandomSpi.java (DEBUG): Likewise.
  * source/gnu/crypto/sig/dss/DSSKeyPairGenerator.java: Likewise.
  * source/gnu/crypto/sig/rsa/EMSA_PSS.java: Likewise.
  * source/gnu/crypto/sig/rsa/RSA.java: Likewise.
  * source/gnu/crypto/sig/rsa/RSAKeyPairGenerator.java: Likewise.
  * source/gnu/crypto/sig/rsa/RSAPSSSignature.java: Likewise.
  * source/gnu/crypto/util/Prime.java: Likewise.

Would it be OK to check in this change?
If you like I can send the actual diff, but it is long and boring.
Should the detailed ChangeLog above be added to some file?

Cheers,

Mark