gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnu-arch-users] [BUG] tla grab fails if the target archive is not y


From: James Blackwell
Subject: Re: [Gnu-arch-users] [BUG] tla grab fails if the target archive is not yet registered
Date: Fri, 27 Aug 2004 12:53:10 -0400

In lists.arch.users, you wrote:
>
> --sdtB3X0nJg68CQEu
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
>
> Hi,
>
> "tla grab" fails without an error message if "Archive-Name" has not yet
> been registered. I suppose the expected behaviour would be that it does
> register the archive.
>
> I've verified the bug with the official tla-1.2 and tla-1.2.1 releases.

Ok. Thats the missing bug. :)

>>      final_revision = find_latest_revision (archive_name, target_revision);
>>      arch_set_archive_location(archive_name, archive_location, 0, 
>> ARCH_REG_FAIL_QUIET);
>>
>>      archive = arch_archive_connect (archive_name, 0);
> [...]
>
> find_latest_revision is called before the archive has been registered!
> Swapping the two lines (find_latest_revision and arch_set_archive_location)
> seems to solve the problem, see the attached patch.

Silly me. Fixed :)

-- 
James Blackwell          Try something fun: For the next 24 hours, give
Smile more!              each person you meet a compliment!

GnuPG (ID 06357400) AAE4 8C76 58DA 5902 761D  247A 8A55 DA73 0635 7400




reply via email to

[Prev in Thread] Current Thread [Next in Thread]