[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Update on OT-SVG in FreeType

From: Moazin K
Subject: Re: Update on OT-SVG in FreeType
Date: Tue, 3 Aug 2021 22:17:26 +0500

I had a quick look at the code, and I've immediately found a
fundamental problem: You are directly accessing
`library->svg_renderer_state`.  This is a no-go for applications since
`FT_Library` is an opaque pointer that must not be dereferenced.

Is it actually necessary that `svg_renderer_state` is a member of
`FT_Library`?  Your SVG code doesn't access it.  If yes, we probably
need a driver property to pass the SVG renderer state structure back
and forth.

Basically, I use that location to store a structure that keeps some caching
data that the one hook writes to while the other one reads from. This avoids
computing the same thing again.

It's not really necessary to store it in FT_Library, if there's any other location
that all the hooks can access, it'd work fine. Do you have other candidates
to store the structure?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]