freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] new CFF engine


From: octoploid
Subject: Re: [ft-devel] new CFF engine
Date: Sat, 04 May 2013 19:35:30 +0200


04.05.2013, 19:13, "Werner LEMBERG" <address@hidden>:
>>  Everything runs error free now. And the 64-bit problem is also
>>  fixed.
>
> Thanks for testing.  Theoretically, I've also fixed clang issues with
> other font formats, but it's easy to miss them...

One last issue:
/var/tmp/freetype2/src/raster/ftraster.c:1827:17: runtime error: left shift of 
negative value -2
/var/tmp/freetype2/src/raster/ftraster.c:1979:18: runtime error: left shift of 
negative value -4
/var/tmp/freetype2/src/raster/ftraster.c:1966:16: runtime error: left shift of 
negative value -7
/var/tmp/freetype2/src/raster/ftraster.c:1968:16: runtime error: left shift of 
negative value -7
...

Should be easy to fix, because it's always the SCALED macro.
IOW something like this should suffice:
-#define SCALED( x )   ( ( (x) << ras.scale_shift ) - ras.precision_half )
+#define SCALED( x )   ( ( (unsigned long)(x) << ras.scale_shift ) - 
ras.precision_half )



reply via email to

[Prev in Thread] Current Thread [Next in Thread]