Re: [PATCH] Re: Make peg.el a built-in library?

[Eric Abrahamsen]

On 11/27/22 10:57 AM, Eli Zaretskii wrote:
>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Cc: emacs-devel@gnu.org
>> Date: Sat, 26 Nov 2022 17:46:04 -0800
>> 
>> Here's a new version, that I hope clarifies these questions (instead of
>> doing the opposite).
>
> Thanks, a few minor comments below.

Thank you! I feel like you've given me many of the same notes in the
past (particularly @xref/@ref), I'll get it eventually.

>> Lastly, nobody with a maintainer's hat on has actually given the green
>> light on this, and I assume we'll want to hold off until the next
>> version of Emacs is released; anyway it would be good to know what
>> Eli/Lars think. I haven't done any NEWS additions or anything, either.
>
> What exactly are you asking about here?

Making peg.el a built-in. I looked back over this whole thread and it
turns out you already gave the OK early on, but now I'm not sure if this
would go in Emacs proper, or as a built-in package... So that's my
question. Where is the natural place to put it?

>> @c -*-texinfo-*-
>> @c This is part of the GNU Emacs Lisp Reference Manual.
>
> This would mean a suitable change to elisp.texi at the least, and probably
> also to another file that is part of the ELisp reference manual sources?

This would depend on how, exactly, it gets included.

[...]

>> @example
>> (defvar number-grammar
>>         '((number sign digit (* digit))
>>           (sign (or "+" "-" ""))
>>           (digit [0-9])))
>
> Btw, this begs a question: how come the value of the variable is a (quoted)
> list, but the value you pass to peg-parse in the previous example was not
> quoted?

peg-parse is a macro, peg-run is a function. peg-parse constructs a call
to peg-run, passing in the car of whatever list you've given to it as
the argument.

The rest of your comments seem straightforward, I'll make those edits
now.

Thanks,
Eric