[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master cfcf42f 2/2: Ensure that gud commands for non-GDB debuggers a

From: Juri Linkov
Subject: Re: master cfcf42f 2/2: Ensure that gud commands for non-GDB debuggers are handled by repeat-mode
Date: Fri, 30 Jul 2021 20:54:11 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> I'm not sure it's a warning.  It's an informative message, and some of
> them are always displayed during bootstrap.  Making them warnings
> would then apply pressure on us to remove them, which we cannot easily
> do in the case of those other messages (unlike the one caused by the
> changeset in this bug).

For example, today's compilation displayed as lot of such lines:

  Warning: Eager macro-expansion skipped due to cycle:
    … => (load "byte-opt.el") => (macroexpand-all …
  Warning: Eager macro-expansion skipped due to cycle:
    … => (load "byte-opt.el") => (macroexpand-all …

I don't know if these are actionable but they are designated as warnings,
and displayed with the same compilation-enter-directory-face
as these unimportant messages:

  Pure-hashed: 16071 strings, 4220 vectors, 41688 conses, 3769 bytecodes, 267 
  make[1]: Entering directory

> My personal advice is to read carefully every line displayed by the
> build process, and not limit yourself to warnings.  Messages that
> aren't supposed to appear during a normal build should be discovered
> regardless of whether they are warnings/errors or not.

It's not realistic to read thousands of lines from every compilation.
It should be enough just to look at the compilation's mode line
to see the total number of errors (in red color), warnings (orange),
and the number of informational messages (in green color).

So if you think such messages are not warnings then
such messages should be detected as informational messages
displayed with the green color that has the corresponding
indicator on the mode line and at the end of the compilation output.

etc/compilation.txt demonstrates the supported syntax:

  foo.c:8:I: message
  foo.c:8.23: note: message
  foo.c:8.23: info: message
  foo.c:8:23:information: message
  foo.c:8.23-45: Informational: message

Another problem is that such syntax requires as least a file name
and a line number that is not always available.  A workaround is
to display a fake name and number.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]