Re: About SASL authentication in rcirc

[Tassilo Horn]

amk@amk.ie writes:

Hi Alex,

> I think the issue is that some of the original sasl commit got lost in
> cherry picking. I've attached a patch that fixes it, I'm not sure if
> there is a better place to send a patch to a branch.

Thanks, after removing the superfluous space between rcirc-auto and
-authenticate-flag in the hunk below, SASL authentication worked fine
for me on libera.chat.

--8<---------------cut here---------------start------------->8---
@@ -685,6 +690,10 @@ that are joined after authentication."
         (rcirc-send-string process "PASS" password))
       (rcirc-send-string process "NICK" nick)
       (rcirc-send-string process "USER" user-name "0" "*" : full-name)
+      ;; Setup sasl, and initiate authentication.
+      (when (and rcirc-auto -authenticate-flag
+                 use-sasl)
+        (rcirc-send-string process "AUTHENTICATE" "PLAIN"))
 
       ;; setup ping timer if necessary
       (unless rcirc-keepalive-timer
--8<---------------cut here---------------end--------------->8---

Philip, I've committed Alex' patch with the whitespace fix on the
rcirc-update branch.

Thank you,
Tassilo