|
From: | Basil L. Contovounesios |
Subject: | Re: RFC: Automatic setup for bug-reference-mode |
Date: | Sun, 14 Jun 2020 19:08:07 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Tassilo Horn <tsdh@gnu.org> writes: > Looks right? I can only comment on one thing: > +(defun vc-bzr-repository-url (file-or-dir) > + (let ((default-directory (vc-bzr-root file-or-dir))) > + (with-temp-buffer > + (vc-bzr-command "info" (current-buffer) nil nil) > + (goto-char (point-min)) > + (when (re-search-forward "parent branch: \\(.*\\)$") Doesn't this need a non-nil NOERROR arg? > + (match-string 1))))) > + Thanks, -- Basil
[Prev in Thread] | Current Thread | [Next in Thread] |