emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master df49910: Create a buffer-local binding to improve performance


From: Stefan Monnier
Subject: Re: master df49910: Create a buffer-local binding to improve performance
Date: Fri, 29 May 2020 00:34:16 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> +  (with-temp-buffer
> +    ;; Each call to ido-ignore-item-p LET-binds case-fold-search.
> +    ;; That is slow if there's no buffer-local binding available,
> +    ;; roughly O(number of buffers).  This hack avoids it.

Hmm... why is it implemented as a DEFVAR_PER_BUFFER?
I think an even better fix is to turn it into a normal DEFVAR_LISP
(together with a `make-variable-buffer-local`).  After all I suspect
that it's rather unusual to set it buffer-locally (it's almost always
let-bound instead).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]