Re: Extend gdb to filter registers

[Eli Zaretskii]

> Cc: address@hidden, address@hidden, address@hidden,
>  address@hidden, address@hidden
> From: martin rudalics <address@hidden>
> Date: Sat, 18 Jan 2020 22:43:46 +0100
> 
>  >>   > gdb-mi.el has gdb-display-buffer, which makes the window dedicated.
>  >>   > It also has some code in gdb-display-source-buffer.  Neither of those
>  >>   > uses display-buffer, AFAICT.  So where do the split thresholds come
>  >>   > into play in the scenario mentioned?
>  >>
>  >> Here
>  >>
>  >> (defun gdb-display-buffer (buf)
>  >>     "Show buffer BUF, and make that window dedicated."
>  >>     (let ((window (display-buffer buf)))
>  >>                    ^^^^^^^^^^^^^^^^^^
>  >>       (set-window-dedicated-p window t)
>  >>       window))
>  >
>  > This function isn't called when gdb-mi.el displays a source file in
>  > its window.
> 
> Above you said that "Neither of those uses display-buffer".  Now
> 'gdb-display-source-buffer' is called exclusively (within gdb-mi.el) by
> 'gdb-goto-breakpoint' which has
> 
>                       (window (or (gdb-display-source-buffer buffer)
>                                   (display-buffer buffer))))
> 
> so if 'gdb-display-source-buffer' fails, 'display-buffer' is called.

So you are saying that calling gdb-display-source-buffer instead of
display-buffer will not by itself help here, because display-buffer is
called under the hood anyway, and might decide to create a new window
instead of reusing an existing one?

If so, what would be the correct solution of this issue?