Re: [Dolibarr-dev] What I do wrong with my PR ?

[Laurent Destailleur (eldy)]

Things are just simple:
Your patch was grabbed the 4th of january so after the 3.5 was frozen. Suggesting a feature after beta is started is always refused.
Any PR that contains a new feature is always added into develop branch, and will be available only for next stable version (any version frozen before will not contains it).

So it will be available with 3.6 version.



Le 31/03/2014 18:27, address@hidden a écrit :

Hi

Ok I've been a bad reading about https://github.com/Dolibarr/dolibarr/tags I'ven't seen beta 3.5 between other 3.4 tags.

Looks enough complicate to propose a patch. Maybe main contributor can follow without problem and know when theirs patches will be released but to external contributor, it's more complicate. We can't know if patch will be accept in next release, or in other next release, or maybe on step over (beta, backport, ...) .

In this case it seems easier to have personnal featured branch and rebase it when stable branch is released and don't propose PR. In this case, patches on stable release can be obtain but it's lost to the community, it's bad :/

I don't know how to do, but looks difficult to try to contribute.

Km

_______________________________________________
Dolibarr-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/dolibarr-dev

-- 
Eldy (Laurent Destailleur).

EMail: address@hidden
Web: http://www.destailleur.fr

Dolibarr (Project leader): http://www.dolibarr.org
To make a donation for Dolibarr project via Paypal: address@hidden
AWStats (Author) : http://awstats.sourceforge.net
To make a donation for AWStats project via Paypal: address@hidden
AWBot (Author) : http://awbot.sourceforge.net
CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net