discuss-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Testers wanted for MPDCon and Zipper


From: Riccardo Mottola
Subject: Re: Testers wanted for MPDCon and Zipper
Date: Wed, 22 Feb 2012 18:52:53 +0100
User-agent: Mozilla/5.0 (X11; OpenBSD i386; rv:5.0) Gecko/20110815 Firefox/5.0 SeaMonkey/2.2

Sebastian Reitenbach wrote:

On Wednesday, February 22, 2012 15:16 CET, Riccardo Mottola<address@hidden>  
wrote:

Hmm,

I notice that the code assagines in several places NSNotFound to a
variable of NSComparisonResult. I feel this is wrong, since it is not
defined in the enum and the type allocated for NSComparisonResult by the
compiler could be different of the one of NSNotFound.
Any suggestions on how to fix this? NSComparisonResult is most probably
signed since it starts with -1.
I think this is totally stupid, and was maybe just incidentally working before 
the NSNotFound change?
We should probably use one of the three values from the _NSComparisonResult 
enum from Foundation/NSObjCRuntime.h


I changed them to NSOrderedDescending, since that is what NSNumber returns if a comparison gives an error. They are init/error values only anyway.

How does compilation fare now?

Riccardo

PS: I'll look into Fred's suggestion about the modal loop later.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]