Re: [cp-patches] Patch PING: java.util.{Currency, Date} and collection classes updates

[Michael Koch]

Am Donnerstag, 21. Oktober 2004 15:16 schrieb Andrew John Hughes:
> On Thu, 2004-10-21 at 09:50, Michael Koch wrote:
> > Am Donnerstag, 21. Oktober 2004 10:26 schrieb Andrew John Hughes:
> > > On Wed, 2004-10-20 at 07:39, Michael Koch wrote:
> > > > Am Mittwoch, 20. Oktober 2004 00:49 schrieb Andrew John 
Hughes:
> > > > > Hi all,
> > > > >  I still have a few patches waiting to be committed from a
> > > > > fair while back.  These are:
> > > > >
> > > > > * Revision 01: Documentation for java.util Collections
> > > > > http://lists.gnu.org/archive/html/classpath-patches/2004-09
> > > > >/msg 0000 4.html
> > > >
> > > > +     * @return "[]".
> > > >
> > > > Should perhaps be '@return the string "[]"'
> > > >
> > > > true and false should be written as "<code>true</code>" to
> > > > make it look a little different in final documentation.
> > > >
> > > > Otherwise very good. Please commit.
> > >
> > > Thanks.  Committed.
> > >
> > > > >* Documentation and serialization patch for
> > > > > java.util.Currency
> > > > > http://lists.gnu.org/archive/html/classpath-patches/2004-09
> > > > >/msg 0000 3.html
> > > >
> > > > +    for (int i=0;i<allLocales.length;i++)
> > > >
> > > > Please add whitespace before and after "=" and "<" and before
> > > > "i++". This makes it much more readable.
> > > >
> > > > Otherwise very good. Please commit.
> > >
> > > Must have missed that one -- I agree it looks ugly and I'm not
> > > the culprit.  Committed.
> > >
> > > > >* Documentation Patch 02 (java.util.Date)
> > > > > http://lists.gnu.org/archive/html/classpath-patches/2004-09
> > > > >/msg 0002 4.html
> > > >
> > > > Okay, but please add a @specnote about when this was changed.
> > >
> > > Can you be a bit more specific here?  Are we talking about a
> > > specific change or something general to the class?  Its a while
> > > since I wrote this one, and all I can see is doc. updates.
> >
> > I meant when was the "transient" keyword added ? or was it always
> > part of the API ? If it was added later it would be good to add
> > something like this into the javadoc:
> >
> > @specnote It was made transient in JDK 1.3
> >
> > (this is only an example)
>
> No wonder I didn't get this -- I posted the wrong link to the
> patch. It should be:
>
> http://lists.gnu.org/archive/html/classpath-patches/2004-09/msg0001
>4.html
>
> which is a patch to java.util.Date.  The patch in that link has
> already been committed, and, AFAIK, the transient was always part
> of the API (it is in 1.3, 1.4 and 1.5 -- docs appear to have gone
> for 1.2)

Please use '(' and ')' for email in @author tags, not '<' and '>' as 
these are HTML entities. If no real email is given just leave it 
away.

Otherwise Ok. Please commit.


Michael

-- 
Homepage: http://www.worldforge.org/