Re: [cp-patches] Patch PING: java.util.{Currency, Date} and collection classes updates

[Michael Koch]

Am Mittwoch, 20. Oktober 2004 00:49 schrieb Andrew John Hughes:
> Hi all,
>  I still have a few patches waiting to be committed from a fair
> while back.  These are:
>
> * Revision 01: Documentation for java.util Collections
> http://lists.gnu.org/archive/html/classpath-patches/2004-09/msg0000
>4.html

+     * @return "[]".

Should perhaps be '@return the string "[]"'

true and false should be written as "<code>true</code>" to make it 
look a little different in final documentation.

Otherwise very good. Please commit.

>* Documentation and serialization patch for java.util.Currency
> http://lists.gnu.org/archive/html/classpath-patches/2004-09/msg0000
>3.html 

+    for (int i=0;i<allLocales.length;i++)

Please add whitespace before and after "=" and "<" and before "i++". 
This makes it much more readable.

Otherwise very good. Please commit.

>* Documentation Patch 02 (java.util.Date) 
> http://lists.gnu.org/archive/html/classpath-patches/2004-09/msg0002
>4.html

Okay, but please add a @specnote about when this was changed.

> There is also:
>
> http://lists.gnu.org/archive/html/classpath-patches/2004-09/msg0005
>9.html
>
> which really needs a Mauve test case before committal.

The documentation parts are okay. Please commit them and provide an 
extra patch only containing the functional changes for easier review 
(perhaps together with mauve tests ;-)


Michael
-- 
Homepage: http://www.worldforge.org/