[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-grep] [PATCH] --initial-tab, 3 newly colorized items, and GREP_

From: Julian Foad
Subject: Re: [bug-grep] [PATCH] --initial-tab, 3 newly colorized items, and GREP_COLORS
Date: Mon, 17 Jan 2005 13:59:06 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041122

Charles Levert wrote:
The background:  parse_grep_colors() stops processing GREP_COLORS as soon
as it encounters something that is ill-formed, while retaining everything
that it processed so far.  I stand by this part of the behavior, since
it is simplest and no behavior in particular is owed when a contract
is broken.


When this happens though, the current patch stays silent about it;
that's the alternative to printing a warning.

My preference would be to print the warning, because I really don't like errors to be ignored silently even if it is a non-essential feature.

- Julian

reply via email to

[Prev in Thread] Current Thread [Next in Thread]