[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-grep] [PATCH] --initial-tab, 3 newly colorized items, and GREP_

From: Charles Levert
Subject: Re: [bug-grep] [PATCH] --initial-tab, 3 newly colorized items, and GREP_COLORS
Date: Sun, 16 Jan 2005 18:32:37 -0500
User-agent: Mutt/1.4.1i

* On Sunday 2005-01-16 at 23:21:14 +0000, Julian Foad wrote:
> Charles Levert wrote:
> >I would like to solicit the following feedback.
> >
> >  -- Should the new parse_grep_colors() print a warning like this:
> >
> >        fprintf(stderr, _("%s: GREP_COLORS is ill-formed at or just before 
> >        remaining substring \"%s\".\n"),
> >                program_name, q);
> What's the alternative(s)?

The background:  parse_grep_colors() stops processing GREP_COLORS as soon
as it encounters something that is ill-formed, while retaining everything
that it processed so far.  I stand by this part of the behavior, since
it is simplest and no behavior in particular is owed when a contract
is broken.

When this happens though, the current patch stays silent about it;
that's the alternative to printing a warning.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]