[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43725: 28.0.50; Include feature/native-comp into master
From: |
Andrea Corallo |
Subject: |
bug#43725: 28.0.50; Include feature/native-comp into master |
Date: |
Thu, 18 Feb 2021 21:56:47 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
[...]
> This should have a big FIXME, since it means the name of the DLL is in
> two different places, and if we need to support a differently-named
> DLL, we are in trouble:
Done with 805cae572a.
> +#ifdef WINDOWSNT
> + /* We may need to load libgccjit when dumping before term/w32-win.el
> + defines `dynamic-library-alist`. This will fail if that variable
> + is empty, so add libgccjit-0.dll to it. */
> + if (will_dump_p ())
> + Vdynamic_library_alist = list1 (list2 (Qgccjit,
> + build_string
> ("libgccjit-0.dll")));
>
> Is there a more elegant way of resolving this difficulty?
I've no precise idea. I guess `dynamic-library-alist` should be
initialized before any compilation can be triggered, not sure how easy
is that, is also something I can't test and as a consequence develop.
> This lacks the ENCODE_FILE part:
>
> + char *fname = SSDATA (concat2 (Vinvocation_directory,
> + XCAR (comp_u->file)));
> + FILE *file;
> + if ((file = fopen (fname, "r")))
>
> And why are you using fopen instead of emacs_fopen?
2110a3faf7 fix both suggestons.
Thanks
Andrea
- bug#43725: 28.0.50; Include feature/native-comp into master, (continued)
- bug#43725: 28.0.50; Include feature/native-comp into master, Eli Zaretskii, 2021/02/20
- bug#43725: 28.0.50; Include feature/native-comp into master, Pip Cet, 2021/02/19
- bug#43725: 28.0.50; Include feature/native-comp into master, Eli Zaretskii, 2021/02/19
- bug#43725: 28.0.50; Include feature/native-comp into master, Andrea Corallo, 2021/02/19
- bug#43725: 28.0.50; Include feature/native-comp into master, Pip Cet, 2021/02/19
- bug#43725: 28.0.50; Include feature/native-comp into master, Andrea Corallo, 2021/02/19
- bug#43725: 28.0.50; Include feature/native-comp into master, Eli Zaretskii, 2021/02/19
- bug#43725: 28.0.50; Include feature/native-comp into master, Pip Cet, 2021/02/19
- bug#43725: 28.0.50; Include feature/native-comp into master, Andrea Corallo, 2021/02/19
- bug#43725: 28.0.50; Include feature/native-comp into master, Andy Moreton, 2021/02/19
bug#43725: 28.0.50; Include feature/native-comp into master,
Andrea Corallo <=
bug#43725: 28.0.50; Include feature/native-comp into master, Andrea Corallo, 2021/02/18