bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#43725: 28.0.50; Include feature/native-comp into master


From: Eli Zaretskii
Subject: bug#43725: 28.0.50; Include feature/native-comp into master
Date: Sat, 20 Feb 2021 08:57:10 +0200

> From: Andrea Corallo <akrl@sdf.org>
> Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org
> Date: Fri, 19 Feb 2021 22:03:32 +0000
> 
> Okay 14e6268d14 is arranging things as follow:
> 
>  #ifdef WIDE_EMACS_INT
>    if (val > LONG_MAX || val < LONG_MIN)
>      return emit_rvalue_from_unsigned_long_long (comp.emacs_uint_type, val);
>  #endif
>    return gcc_jit_context_new_rvalue_from_long (comp.ctxt,
>                                                 comp.emacs_uint_type,
>                                                 val);

Thanks.

> >> 'emit_rvalue_from_unsigned_long_long' was added by me as libgccjit so
> >> far has no long long support.  As this is shifting the numeric argument
> >> to emit the code that re-create the long long equivalent using an
> >> unsigned was the natural choice to avoid UB.
> >>
> >> Admittedly we could just cast inside
> >> 'emit_rvalue_from_unsigned_long_long' and rename it into
> >> 'emit_rvalue_from_long_long' but I'm not sure is that important.
> >
> > Either that, or some comment would be good enough.
> 
> I realized we already had also the signed variant so with 92fe7a91f4 I
> removed the unsigned one and we always use 'emit_rvalue_from_long_long'
> now.

Great, thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]