bug#43725: 28.0.50; Include feature/native-comp into master

[Pip Cet]

On Fri, Feb 19, 2021 at 2:16 PM Andrea Corallo <akrl@sdf.org> wrote:
> >> > comp.c:1174:22: warning: logical ‘or’ of collectively exhaustive tests 
> >> > is always true [-Wlogical-op]
> >> >  1174 |   if (val > LONG_MAX || val < LONG_MIN)
> >> >       |                      ^~
> >> >
> >> > Not sure what's the best way to silence it or if we want to revert to
> >> > the previous formulation.
> >>
> >> Maybe it's me, but I had a hard time parsing that warning. IIUC, the
> >> tests are both trivially false? And oring two trivially false
> >> conditions shouldn't trigger a warning, should it?
> >
> > No, I think it tries to say that val is always either greater than
> > LONG_MAX or smaller than LONG_MIN.
>
> Exactly, the warning is about the fact that all the other conditions
> will never be evaluated.  The phrasing is admittedly quite cryptic tho.

I thought you said this was a setup where the argument _does_ fit a long?