bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing e


From: npostavs
Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore
Date: Sat, 24 Dec 2016 10:34:50 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

tags 25157 fixed
close 25157 26.1
quit

Reuben Thomas <address@hidden> writes:

>  >>
>  >> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data
>  >> is the call of re-search-forward.
>  >>
>  >> I'm not sure this is a sufficient explanation of why save-match-data is
>  >> needed. Usually in Emacs the caller is responsible for saving the match
>  >> data, if it needs to. I don't really see the need here.
>  >
>  > Can it be removed then?
>
>  Probably yes.
>
> ​Great; can you then install a suitable patch, please?

I've pushed the first patch as cf5417f02887 "Fix whitespace eob
cleanup", removed save-match-data in da52e939aa26 "Remove redundant
`save-match-data' in whitespace.el".





reply via email to

[Prev in Thread] Current Thread [Next in Thread]