bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing e


From: Reuben Thomas
Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore
Date: Fri, 23 Dec 2016 10:44:54 +0000

On 23 December 2016 at 00:03, <address@hidden> wrote:
Reuben Thomas <address@hidden> writes:

> On Dec 22, 2016 2:17 AM, <address@hiddennet> wrote:
>> >
>> > The only thing I'd change in your match is, as in mine, remove the FIXME after save-match-data.​
>>
>> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data
>> is the call of re-search-forward.
>>
>> I'm not sure this is a sufficient explanation of why save-match-data is
>> needed. Usually in Emacs the caller is responsible for saving the match
>> data, if it needs to. I don't really see the need here.
>
> Can it be removed then?

Probably yes.

​Great; can you then install a suitable patch, please?

--

reply via email to

[Prev in Thread] Current Thread [Next in Thread]