bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing e


From: npostavs
Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore
Date: Thu, 22 Dec 2016 19:03:53 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Reuben Thomas <address@hidden> writes:

> On Dec 22, 2016 2:17 AM, <address@hidden> wrote:
>> >
>> > The only thing I'd change in your match is, as in mine, remove the FIXME 
>> > after save-match-data.‚Äč
>>
>> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data
>> is the call of re-search-forward.
>>
>> I'm not sure this is a sufficient explanation of why save-match-data is
>> needed. Usually in Emacs the caller is responsible for saving the match
>> data, if it needs to. I don't really see the need here.
>
> Can it be removed then?

Probably yes.

> The only perhaps unexpected thing I can think of is that whitespace-cleanup 
> can be called from a hook, such as save-file-hook, but that
> doesn't seem to matter.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]