[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23290: 25.1.50; eww: Symbol’s value as variable is void: url-http-re

From: Tao Fang
Subject: bug#23290: 25.1.50; eww: Symbol’s value as variable is void: url-http-response-status
Date: Sun, 17 Apr 2016 01:19:01 +0800
User-agent: Emacs/Gnus

Hi, Michael

After some digging, I found a code bug in commit
3c623c26ae7d695746e05d8a2e16a67a6256b024 introduced by me and maybe
relavant to your report.


  1319  (defun url-https-proxy-after-change-function (st nd length)
  1327        (url-http-parse-response)
  1328        (cond
  1360         (t
  1361          (url-http-activate-callback)
  1362          (message "error response: %d" url-http-response-status))))))

When using url-http in eww and the above "cond" last clause succeed
(i.e. at first connecting to proxy response not HTTP 200), 
"url-http-activate-callback" will call
function "eww-render" which calls (kill-buffer), so the code next line
visit symbol url-http-response-status will cause the error: "Symbol’s
value as variable is void: url-http-response-status".

This can be fixed simplely transpose that two code lines:

Attachment: 0001-fix-void-variable-url-http-response-status.patch
Description: Text Data

Can you help to apply the patch and test on that in your environment?

And I'm not sure about this, because only using https proxy will enter
this function(if I do it right?), I still need to find out about it.

Thanks for your help!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]