[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] Glade msgctxt patch

From: Daiki Ueno
Subject: Re: [bug-gettext] Glade msgctxt patch
Date: Thu, 14 Mar 2013 11:16:00 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Miguel Ángel Arruga Vivas <address@hidden> writes:

> I actually prefer arglist_parser functions family, because It eases a
> little bit GtkBuilder implementation, but there is no real problem,

I'm looking at:

Right.  It might help for the case where context is passed differently.

However, it looks a bit hacky to me that arglist_parser functions are
used without other callshape API functions, unlike other parsers.

Maybe you can get some inspiration from Bruno's original commit which
introduced the API:

So, if I were you, I would try:

1. register keywords using split_keywordspec, like:

  x_glade2_keyword ("property:1g");
  x_gtkbuilder_keyword ("property:1c,2");

2. allocate arglist_parser in start_element callback
3. call arglist_parser_remember in start_element and end_element if we
   find something to remember in attributes and contents
4. call arglist_parser_done in end_element 

though it might not fit well with the SAX-style parser.

> My local repo already has every patch I have done, feel free to ask
> for old (and probably buggy) versions.


> Also, for the tests patch, should I split msgctxt extraction test
> (xgettext-glade-5) and atkproperty test case (xgettext-glade-4) in two
> commits?

Yes, please.  The atkproperty test case is not related to the context
support, right?  Also perhaps it might be good to add a wrong element to
the xgettext-glade-5 to test the failure case.

I'm looking at:

Daiki Ueno

reply via email to

[Prev in Thread] Current Thread [Next in Thread]