[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gettext] Glade msgctxt patch

From: Miguel Ángel Arruga Vivas
Subject: Re: [bug-gettext] Glade msgctxt patch
Date: Thu, 14 Mar 2013 21:29:42 +0100

Daiki Ueno <address@hidden> writes: 
> Miguel Ángel Arruga Vivas <address@hidden> writes:
> > I actually prefer arglist_parser functions family, because It eases a
> > little bit GtkBuilder implementation, but there is no real problem,

Nevermind. It is not optimal because...

> However, it looks a bit hacky to me that arglist_parser functions are
> used without other callshape API functions, unlike other parsers.

... using keyword splitting is as hacky as this for a stream parser, as
you noticed...

> though it might not fit well with the SAX-style parser.

... here. Numbered arguments does not fit in xml parsing. I think you
(and Bruno when he did It) were right with the call remember_a_message

> > Also, for the tests patch, should I split msgctxt extraction test
> > (xgettext-glade-5) and atkproperty test case (xgettext-glade-4) in two
> > commits?
> Yes, please.  The atkproperty test case is not related to the context
> support, right?  Also perhaps it might be good to add a wrong element to
> the xgettext-glade-5 to test the failure case.

Done. See the next mail (and or my github repo -> glade_fixes).

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]