bug-gawk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] gawk erroneous comparison with large negative exponents


From: Andrew J. Schorr
Subject: Re: [bug-gawk] gawk erroneous comparison with large negative exponents
Date: Tue, 14 Apr 2015 10:35:27 -0400
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Apr 14, 2015 at 04:00:46PM +0300, Aharon Robbins wrote:
> > Regarding gawk, this does raise the question of whether 
> > node.c:r_force_number
> > should force the numeric value to zero when strtod sets errno.
> 
> I think it should.
> 
> Andy, do you want to do that in the stable branch and see if anything
> breaks in the test suite?  If that's OK, please push, merge to master,
> and push that as well.  I've done enough beating on gawk for one day...

The attached patch breaks two tests:

============== _arraysort =============
*** arraysort.ok        2015-04-06 08:40:06.419766000 -0400
--- _arraysort  2015-04-14 10:32:45.176667000 -0400
***************
*** 61,83 ****
  |D3|D3|
  --asc ind num--
  |0|0|
  |D3|D3|
  |1|1|
  |2|2|
  | 3| 3|
  |3|3|
- |3D|3D|
  | 4 | 4 |
  |4|4|
  |5|5|
  --asc val num--
  |0|0|
  |D3|D3|
  |1|1|
  |2|2|
  | 3| 3|
  |3|3|
- |3D|3D|
  | 4 | 4 |
  |4|4|
  |5|5|
--- 61,83 ----
  |D3|D3|
  --asc ind num--
  |0|0|
+ |3D|3D|
  |D3|D3|
  |1|1|
  |2|2|
  | 3| 3|
  |3|3|
  | 4 | 4 |
  |4|4|
  |5|5|
  --asc val num--
  |0|0|
+ |3D|3D|
  |D3|D3|
  |1|1|
  |2|2|
  | 3| 3|
  |3|3|
  | 4 | 4 |
  |4|4|
  |5|5|
============== _hex =============
*** hex.ok      2015-04-06 08:40:06.964767000 -0400
--- _hex        2015-04-14 10:32:43.571616000 -0400
***************
*** 1,6 ****
! 1 600000
  06e5(x)
! 0600001
  03e2(ex)
  1000
  00.3
--- 1,6 ----
! 0 0
  06e5(x)
! 00
  03e2(ex)
  1000
  00.3
make[1]: Leaving directory `/nfs/netapp/home/users/schorr/src/gawk/master/test'

I have not yet had a chance to troubleshoot.

Regards,
Andy

Attachment: subnormal.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]