Re: [bug-diffutils] bug: diff -r swaps the files it should check

[Paul Eggert]

On 08/08/2011 10:04 AM, Eric Blake wrote:

> Then diffutils should explicitly include 'largefile' in its list of
> required modules

Yes, that'd be reasonable.  Full patch enclosed below.  I'm not applying
this, though, as a new release is imminent and this patch does not fix
any bugs.

> I still argue that it is wrong to duplicate AC_SYS_LARGEFILE if we
> are explicitly depending on a gnulib module documented to guarantee
> that same aspect.

Only the 'largefile' module is documented to do that.  And it doesn't
sound right for other modules to document that; outsiders should not
be relying on their internals.

>From e98f73d8e5eee5a1345c22484172738f69698d0d Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Mon, 8 Aug 2011 21:52:07 -0700
Subject: [PATCH 1/2] build: update gnulib submodule to latest

---
 gnulib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gnulib b/gnulib
index 8068b5d..30b5bd2 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 8068b5d283630a295b2929b9dc6a65916b10f52f
+Subproject commit 30b5bd2f22154ae7b9f81b91632830d82a4f1fb3
-- 
1.7.4.4


>From b2c25e40637ff6b378a6dc8d4e41aa7b23f085d2 Mon Sep 17 00:00:00 2001
From: Paul Eggert <address@hidden>
Date: Mon, 8 Aug 2011 22:03:50 -0700
Subject: [PATCH 2/2] configure: use gnulib largefile module

* bootstrap.conf (gnulib_modules): Add largefile.
* configure.ac (AC_SYS_LARGEFILE): No need to invoke directly;
gl_EARLY now does that for us.  Suggested by Eric Blake in:
http://lists.gnu.org/archive/html/bug-diffutils/2011-08/msg00030.html
---
 bootstrap.conf |    1 +
 configure.ac   |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 5aa783b..e6a76b4 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -46,6 +46,7 @@ gnupload
 hard-locale
 inttostr
 inttypes
+largefile
 maintainer-makefile
 manywarnings
 mbrtowc
diff --git a/configure.ac b/configure.ac
index 1afc344..a92d950 100644
--- a/configure.ac
+++ b/configure.ac
@@ -38,7 +38,6 @@ AM_MISSING_PROG([HELP2MAN], [help2man])
 AC_PROG_RANLIB
 gl_EARLY
 gl_USE_SYSTEM_EXTENSIONS
-AC_SYS_LARGEFILE
 gl_INIT
 
 AC_ARG_ENABLE([gcc-warnings],
-- 
1.7.4.4