Re: [bug-diffutils] bug: diff -r swaps the files it should check

[Eric Blake]

On 08/08/2011 09:54 AM, Paul Eggert wrote:
> On 08/08/2011 08:44 AM, Eric Blake wrote:
> > once you update to the latest gnulib, you may want to remove this redundant 
> > line:
>
> I don't see that as a redundancy.  Diffutils accesses the
> file system directly, as well as via gnulib.  If gnulib were
> to change such that it didn't need to access the file system
> (admittedly unlikely), then gnulib could drop the dependency;
> but diffutils would still need it.

Then diffutils should explicitly include 'largefile' in its list of 
required modules, as in:

diff --git i/bootstrap.conf w/bootstrap.conf
index 5aa783b..e6a76b4 100644
--- i/bootstrap.conf
+++ w/bootstrap.conf
@@ -46,6 +46,7 @@ gnupload
 hard-locale
 inttostr
 inttypes
+largefile
 maintainer-makefile
 manywarnings
 mbrtowc

I still argue that it is wrong to duplicate AC_SYS_LARGEFILE if we are 
explicitly depending on a gnulib module documented to guarantee that 
same aspect.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org