[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make AC_COMPUTE_INT public

From: Ralf Wildenhues
Subject: Re: [PATCH] Make AC_COMPUTE_INT public
Date: Thu, 22 Jun 2006 10:26:19 +0200
User-agent: Mutt/1.5.11

* Paolo Bonzini wrote on Thu, Jun 22, 2006 at 09:27:01AM CEST:
> >>I have a problem with the change.  The public AC_COMPUTE_INT macro
> >>should use AC_MSG_CHECKING and AC_MSG_RESULT to announce what it's
> >>doing.  Arguably, it should also cache the value of VARIABLE.
> >
> >Agreed, on both counts.
> I'd rather leave this to the caller.  In particular, it's not very easy 
> to find a name for the cache variable without breaking compatibility 
> with earlier users of _AC_COMPUTE_INT.  For example, AC_CHECK_ALIGNOF
> uses "(long int) offsetof (ac__type_alignof_, y)" as the argument, no 
> matter what type's alignment is being tested.

Hmm.  Guess I wasn't very thorough on this call either.

In any case, the resulting discussion about this alone is another
argument against publishing this macro now.  Let's concentrate on
show stoppers only for now.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]